refactor: Refactor prefixes #99
Merged
+198
−131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micha91
requested changes
Aug 22, 2024
There was a problem hiding this comment.
Some conceptual recommendations - first I wasn't convinced of the general approach of moving the prefixes to the config, but I think this would be a great opportunity to add additional flexibility to the link config and enable the user to define the custom fields individually while having save defaults
micha91
requested changes
Aug 23, 2024
|
I don't know how the tests fail. The test doesn't exist like that with the parametrization anymore. So the tests are not in the state of the latest commit. |
Instead of adding them during the serialization
Co-authored-by: micha91 <[email protected]>
ewuerger
force-pushed
the
refactor-prefixes
branch
from
69f7f16 to
d27e28d
Compare
micha91
requested changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the handling of prefixes (type_prefix and role_prefix) such that these are added during loading of the configuration instead of adding them during the serialization of
WorkItems orWorkItemLinks.